[Logins] Parsing problems with logins.json resulting in empty logins

[suamor]

What happened?

Basic mistakes: I updated from G3 to G4 some time ago. I had not used the browser so far. Started waterfox-g4 G4.1.2.1 I have converted an old profile to G4. Worked splendid (history, bookmarks etc. everything works) I tried to use login manager - worked, could store new passwords (not checked logins)

1. Opened up login manager: No logins in the list
2. Disabled all addons: No change, logins are invisible.
3. Restarted in Troubleshoot mode: No change, logins list is empty.

Now I checked logins.json in text editor: All logins are present. Exit waterfox-g4 G4.1.2.1 I made backup of logins.json file and deleted the file. 4. I added a new account. 5. Login is not shown in login manager 6. Restarted in Troubleshoot mode: Login is visible in Login manager 7. Exit waterfox-g4 8. Replace account with one from backup 9. Start again in Troubleshoot mode 10. Login is not shown in Login manager

So I identified 2 problems. First problem is that after import logins do not appear in login manager Second problem is that the newly created json file from import causes situation that login manager no longer works. In Troubleshoot mode login manager only works when having added accounts from browser, but not from import.

Here is the format that works for me in troubleshoot mode: {"nextId":2,"logins":[{"id":1,"hostname":"https://accounts.google.com","httpRealm":null,"formSubmitURL":"","usernameField":"","passwordField":"","encryptedUsername":"YourWish","encryptedPassword":"IsNotGranted","guid":"{a4524826-0d1b-4984-85d5-8d1393b48bea}","encType":1,"timeCreated":1655528835165,"timeLastUsed":1655528835165,"timePasswordChanged":1655528835165,"timesUsed":1}],"potentiallyVulnerablePasswords":[],"dismissedBreachAlertsByLoginGUID":{},"version":3}

Here is the format that does not work or me at all: {"nextId":2,"logins":[{"id":1,"hostname":"https://accounts.google.com","httpRealm":null,"formSubmitURL":"https://accounts.google.com","usernameField":"identifier","passwordField":"password","encryptedUsername":"YourWish","encryptedPassword":"IsNotGranted","guid":"{e8643060-8dae-4c99-9a69-ccde69adcd96}","encType":1,"timeCreated":1525616000293,"timeLastUsed":1623998450340,"timePasswordChanged":1615401922357,"timesUsed":9}],"potentiallyVulnerablePasswords":[],"dismissedBreachAlertsByLoginGUID":{},"version":3}

Generally I see only differences in content, but fields are the same. The encrypted user name / password are different. I saw that the content only partially matches and length is different.

Is it possible that user name / password could not be decrypted?

Please check and fix issue with logins.json not correctly parsed.

Reproducible?

• [x] I have tested this on Firefox.

Version

G4

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Workaround (not working)

Firefox: Same method as above, issues are reproducible unfortunately. I checked json files from both imports and they look the same.

[suamor]

I tested with new profiles as well (both firefox and waterfox-g4). No difference. The password manager does not show my password list.