BrowserWorks
Several cosmetic issues on G4. Please fix.
What happened?
Waterfox G4.0.0b1, macOS Big Sur 11.6
@adamp01 @MrAlex94
I found several cosmetic issues on G4 that need addressing before anything is released.
- Waterfox Lepton: The loudness indicator is broken in the tab where any video / audio plays. Try it with any YouTube video and you shall see.
- Waterfox's settings still contain several greyed out items that need to be removed, mainly on about:preferences#general and on about:preferences#home
- about:protections still advertises various Mozilla services. I have already criticized this for G3, please remove these ads.
- Several of the settings of @hawkeye116477 are still missing.
Minor nitpicks / wishes:
- Why aren't Lepton Light and Lepton Dark specifically selectable? Why only according to the system theme?
- Whatever happened to the Australis-inspired themes of G3, please reintroduce those (maybe in a later release).
Thank you for your attention.
Reproducible?
- [ ] I have tested this on Firefox.
Version
G4.𝑋 (Future)
What platform are you seeing the problem on?
macOS
Relevant log output
No response
Thanks @Peacock365 - I'll be sorting out all the about:preferences related stuff today.
@adamp01
Thanks for the quick reply the loudness indicator graphical issue especially drives me mad though.
@Peacock365
Would you be able to highlight what you are seeing vs. what you expect please? I was quickly comparing G3 with G4 and couldn't spot a difference - if you have some screenshots that'll help me pick up on what I'm missing
@adamp01
- Set Waterfox Lepton as your theme.
- Go to any YouTube video.
- Look at the tab the video plays in.
- Success.
@adamp01
To be clear, when the Waterfox Lepton theme is used, is the loudness indicator meant to sit at the top right of the tab's favicon when a video plays within that tab? Because it sure as hell looks broken.
@Peacock365
This is the intention of the theme creator, yes. The reason for this is due to Mozilla updating where the Mute Tab overlay is rendered, thus making it impossible to do much with just css. If you take a look here: https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser-tab.js#23
The tab-icon-overlay is the class that the Mute Tab overlay falls into. It would be possible to amend this and move that line down to just above the tab-close-button on line 39, but that would break the Proton theme for users who prefer that (and probably give us some merge conflicts when pulling from Firefox at some point).
Whilst I do agree the overlap of the overlay and the favicon isn't the most appealing of things, I think it is still preferable to how Proton handles things:
Vs. Lepton:
@adamp01
So, in effect, this is not a bug, but a feature? No offense, but that looks horrible. Really, it does. Two possible fixes:
- When a video plays, replace the favicon of the tab with the loudness indicator, as is the case already with Proton.
OR
- Move the loudness indicator to the left of, and in immediate proximity to, the close button.
The way it looks now, it seems like a bug. Again, no offense, I like the rest of the theme as it is.
@Peacock365
I might add in an option to change how it looks at some point, but it's not at the top of the priority list right now.
@adamp01
I have found several other issues as well, in addition to the ones already mentioned:
- Tracking protection doesn't seem to work at all. No matter on which website. It seems like Waterfox no longer connects to the Shavar domain (Have you removed it in the config?) from which Firefox receives its list updates. Please fix.
- When a light theme is used, including the bundled ones, the "Waterfox" text on the New Tab Page appears white-on-white and is thus hardly readable. Dark themes are OK.
- In the Chrome Web Store, the "Add to Waterfox" button only appears upon reload.
- In the Chrome Web Store and the Opera Store, trying to add any extension results in "undefined - This add-on could not be installed because it has not been verified" - Are you sure the disabling extension signing (xpinstall.signatures.required) has actually worked?
- On the Mozilla add-ons website, probably due to the different user agent, "Install Firefox" appears on every add-on page instead of "Add to Firefox".
So this thread is up to date:
Tracking protection should be resolved with this: https://github.com/WaterfoxCo/Waterfox/commit/cd8b58d31eb673674be27b4bc82b6d72056eda92 Signature required issue should be resolved with this: https://github.com/WaterfoxCo/Waterfox/commit/fdb9a7ebc7b7dc459634e098f33acf128bbff3c8 Chrome web store issue should be resolved with this: https://github.com/WaterfoxCo/Waterfox/pull/2305
https://github.com/WaterfoxCo/Waterfox/commit/6391c21385e5ad6982dd1231ed64191342a84164
This should be the last of the issues resolved.
I'll close this unless you think there's anything unresolved.
Here is another few issues I have found, but not sure if they are bugs (as of Waterfox G4.0.0b2):
- For some extensions in the Chrome Web Store and Opera Store, when you try to add them, the following text appears: "This add-on could not be installed because not all of its features are supported". Here are two examples (just for reference):
https://chrome.google.com/webstore/detail/metamask/nkbihfbeogaeaoehlefnkodbefgpgknn
https://addons.opera.com/en/extensions/details/ublock/
Now, I am not sure whether or not Waterfox is genuinely missing certain APIs or if these extensions just don't recognize existing APIs. So not sure if this is a bug or not.
- There seems to be a bug with the settings, go to about:preferences#home, reload the page. The "Recent Activity" section vanishes and curiously, the "Recent Activity" section on about:newtab also goes away despite "Recent Activity" being enabled under the clogwheel icon on about:newtab.
- Perhaps connected to the settings bug above: Go to about:preferences#home, reload the page and get the bug described above, then switch to about:preferences#general, there you'll get duplicate settings all of a sudden (same settings appear twice), this seems to only affect the "hawkeye" settings added by @adamp01 and not the preexisting Firefox settings.
- hawkeye's WebRTC, referrer header, geolocation settings are still missing under about:preferences#privacy
- I noticed that Waterfox does not display add-on version numbers on about:addons, please add this back. It suuuuuuucks without version numbers, you see.
- Waterfox still connects to firefox.settings.services.mozilla.com all the time... Are you sure that there is no way to fix this at the code level?
- Don't forget to purge the system add-ons. I think "DoH Roll-Out 2.0.0" should not exist in Waterfox. I would not hijack users in the same way Mozilla does. If someone wants DoH, the settings are there. If not, leave the user alone.
- Still unresolved: about:protections still advertises various Mozilla services. I have already criticized this for G3, please remove these ads
@MrAlex94, please reopen the issue for the time being. Thank you.
@Peacock365 I'll get back on the about:preferences stuff and fix it in the React code instead, that should solve those issues. Thanks for pointing out the other missing settings as well. I'll also take a look at the telemetry stuff with some urgency.
The rest I'll make a note of but will just go into general prioritisation.
To be honest, all the things I mentioned are probably high priority. If they were not, I would not have mentioned them specifically. Good to hear that at least some of them will be fixed ASAP.
For some extensions in the Chrome Web Store and Opera Store, when you try to add them, the following text appears: "This add-on could not be installed because not all of its features are supported". Here are two examples
That's because Firefox doesn't support every WebExtension API.
Waterfox still connects to firefox.settings.services.mozilla.com all the time... Are you sure that there is no way to fix this at the code level?
Yes, even Tor still keeps these connections.
Please don't forget the scheduled telemetry task on Windows, please disable at build level: https://www.ghacks.net/2020/04/09/mozilla-installs-scheduled-telemetry-task-on-windows-with-firefox-75/
That's because Firefox doesn't support every WebExtension API.
Are you sure about that? I am even getting this for extensions that I was able to add to Waterfox G3. And the overall number of extensions for which this message appears is very high, too.
Yes, even Tor still keeps these connections.
Was there any specific reason why or were they just not able to remove it? Genuinely curious here.
This is already disabled.
Ah, OK. Thanks. I've edited my comment above as well to reflect this.
@MrAlex94
Is this a potential fix for firefox.settings.services.mozilla.com ?
https://wiki.archlinux.org/title/Firefox/Privacy#Editing_the_contents_of_omni.ja
Are you sure about that? I am even getting this for extensions that I was able to add to Waterfox G3. And the overall number of extensions for which this message appears is very high, too.
Yes I'm sure. If you have examples of ones that work on G3 and don't on G4, let us know.
Was there any specific reason why or were they just not able to remove it? Genuinely curious here. Is this a potential fix for firefox.settings.services.mozilla.com ?
What that guide suggests is a terrible idea. The browser will output a bunch of noise complaining about lack of connections and it does break things when it can't access those JSON dumps. It's used for everything from HSTS pinning to addon blocklists.
What that guide suggests is a terrible idea. The browser will output a bunch of noise complaining about lack of connections and it does break things when it can't access those JSON dumps. It's used for everything from HSTS pinning to addon blocklists.
OK, fine. I relent. There seem to be good reasons for why this connection was kept then.
Hello? I am the author of Lepton Theme.
I came across it by chance while doing a search. I'm happy to be able to make a small contribution from a fork as old as Waterfox.
Whilst I do agree the overlap of the overlay and the favicon isn't the most appealing of things, I think it is still preferable to how Proton handles things:
Let me explain the intent when determining the overlay location. In the case of the general tab, I was thinking of placing it right behind the favicon like Edge. However, it has the current design for the following reasons.
- Consistency: I wanted similar usage for both fixed tabs and normal tabs. UX consideration for muscle memory.
- Padding: I wanted to show as much information as possible within the limited tab space.
And here's why I removed the label.
- Language: English supports labels, but some languages do not. So, I removed all the labels and made them expressed as icons (sound, PIP).
The sound icon in the screenshot should be raised by about 3.5px to cover less of the favicon.
It worked correctly in 1.0.0, but I think there was a mistake in the recent version while refactoring.
Fortunately, a bug report has arrived and has been fixed in the latest version released recently.
https://github.com/black7375/Firefox-UI-Fix/releases/tag/v4.2.2
Why aren't Lepton Light and Lepton Dark specifically selectable? Why only according to the system theme?
I'm making it, but the lepton is pretty complex. Looking inside, it is divided into the following modes:
- System Default Theme:
- Windows7 dedicated theme
- GTK, Windows10 accent color support
- (Dev branch) Win10, Mac's dedicated theme
- Light weight Theme
- Built-In Light Theme: Enhances contrast.
- When Dark Mode: Apply dark mode to some content.
Therefore, it may take some time to provide the theme. Anyway, it would be cool if you could see system default, light and dark mode. If waterfox maintainer or developers ever need my help, I can give you some advice.
I'm very excited to meet my project at Waterfox, thank you again.
@black7375, thank you for the informative post! It is a great theme which is why it has been set as default 👍
Why aren't Lepton Light and Lepton Dark specifically selectable? Why only according to the system theme?
This is more related to Waterfox - and will be coming in a future update.
If we can help in any way with the themeing do let us know!
Additional issues I have found:
- under about:license, the following text appears at the top of the page: "Binaries of this product have been made available to you by the Mozilla Project under the Mozilla Public License 2.0 (MPL). Know your rights." Please change to "Waterfox Limited".
- When the Waterfox Australis Light theme is used, the tabs are hardly visible. Please give them a darker shade.
@adamp01
Please react to my prior comment, the previous two issues still persist as of Waterfox G4.0.3.1
Additionally, I have found the following issues:
- When Waterfox is maximized (green maximize button at the top left of the window) under macOS, the tabs are moved to the right quite a bit. The last version of Waterfox with correct behavior was Waterfox G4.0.2.1.
- Google search suggestions don't work.
- When the Australis theme is used, the close / minimize / maximize button are moved from their normal position on macOS.
@Peacock365
- I'll sort the license now.
- I'll also sort the Australis Light tab colour as it's a super quick fix. I'll also see if I can quickly fix up the moving close etc. buttons.
- I've added Google search suggestions onto the backlog as will need a bit of investigative work.
- For the tab movement when maximized issue, could you send me a screenshot? It all seems OK for the Mac installations I've tested, but if I see the issue I may be able to implement something to fix. Might also be handy if you could show me the elements around it in Tools -> Browser Tools -> Browser Toolbox.
@adamp01
I just wanted to ask: What is the status of add-on version number restoration in about:addons? Seeing the current version number would be handy since it makes updates more visible and may help when resolving add-on issues here. It seems like a trivial(?) fix to add this back, please make this a priority.
I have found two further issues (Waterfox G4.0.8):
-
In the Chrome Web Store, trying to add some extensions now triggers a download window for the CRX file. This should not happen, either the user gets notified when an API is missing or the extension should get added. Downloading the CRX file is not a possible outcome. Some random examples of extensions where this happens: https://chrome.google.com/webstore/detail/twitch-fullscreen-plus/jbbmdehmiclndmeedcocofcjlpgjnmea and https://chrome.google.com/webstore/detail/dark-reader/eimadpbcbfnmbkopoojfekhnkhdbieeh
-
In the Opera Store, the "Add to Waterfox" button is rendered incorrectly when trying to add any extension.
Further wish list:
- Is there a reason why the Edge extension store is not supported? https://microsoftedge.microsoft.com/addons/Microsoft-Edge-Extensions-Home
@Peacock365 - I'll look into the addon version number today.
Thanks for raising those issues with the addon store compatability piece, I'll take a look at this as well.
We haven't had as much capacity as we had hoped for so this hasn't been getting as much attention as it needs, as such we don't have the time currently to look into expanding to Edge. Our priority would be introducing compatability for externally_connectable to improve the amounts of addons compatible with Waterfox.
@Peacock365 - For the addon version number, it is displayed on the card detail like below:
That should be sufficient no? Or are there cases you have seen where this is not being displayed?
@adamp01
No, I mean the add-on version number in the add-on list, directly in about:addons (list view of all extensions). Waterfox Classic had it, Waterfox G3 had it, Waterfox G4 doesn't. You patched it back in in Waterfox G3 as well I recall. Having the add-on version number directly in the list view is better than what we have now because 1) updates are immediately visible from the list view, no need to click through all extensions to see if and when anything has been updated and 2) it makes troubleshooting easier because users are more likely to post the version number of the add-on if it is outright displayed in the list view. I mean, minimalism has its benefits, but Mozilla has been taking it a step too far here, please patch the add-on version number in the list view of all add-ons back in. Should not be hard to do. You also list this as an unresolved issue on your website btw:
https://www.waterfox.net/docs/releases/G4.0.8
I have found one further issue:
- When in a hotel or in public places or public transport, Waterfox can fail to connect to public WiFi hotspots. Source: It failed on me, Firefox worked. This is caused by you developers disabling network.captive-portal-service.enabled in the Waterfox-specific about:config preferences. Please remove this setting from the Waterfox-specific settings (000-waterfox.js), as it breaks Waterfox's ability to detect and connect to public WiFis.
@Peacock365 - gotcha, I'm PR'ing something to make it look like this:
I'll speak to Alex about flipping network.captive-portal-service.enabled as well.
Also, I did take a look at the addon stores stuff yesterday and I've noticed that sometimes the content handler picks up the x-chrome-extension type and attempts to install the addon correctly, and other times (seemingly at random) it won't and attempts to download it. Might take a minute to figure out what the root cause is here, as profiling was rather unhelpful.
I also didn't notice any rendering issues on the Opera web store, could you give me some additional details around what you are seeing?