core icon indicating copy to clipboard operation
core copied to clipboard

Add color-usage-viewer page

Open margaree opened this issue 2 months ago • 8 comments

Jira ticket

margaree avatar Nov 17 '25 14:11 margaree

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-6320/

[!NOTE] The build needs to finish before your changes are deployed. Changes to the PR will automatically update the instance.

github-actions[bot] avatar Nov 17 '25 14:11 github-actions[bot]

Cool!

dbatiste avatar Nov 19 '25 18:11 dbatiste

Jeff has requested this go in so it lives on our core live site (or somewhere easier to access). Let me know thoughts on where this code should actually live. e.g., since these aren't real core components/official scripts we'd want everyone using, though the data is specific to core at this point. I was also thinking of putting up a hidden page in Daylight so we could capture colors from other places so perhaps it should all just live there?

margaree avatar Nov 21 '25 15:11 margaree

Is the hope that this is rerun automatically on like a daily/weekly basis as changes are made, or forever a mostly manual process? If we wanted it automated, I don't think it'd be too hard to create a colours.d2l.dev repo and site, and have the automation check out core and run the scripts. It likely couldn't/shouldn't check out the LMS though. 🤔

Edit to add: And even if it was to remain manual, I don't think a dedicate live site would be that much work

svanherk avatar Nov 21 '25 15:11 svanherk

Yesterday we spoke briefly about other properties that we might want included from a broader theming perspective. We might consider tweaking this a bit for the more general "theme" case.

dbatiste avatar Nov 21 '25 15:11 dbatiste

Is the hope that this is rerun automatically on like a daily/weekly basis as changes are made, or forever a mostly manual process? If we wanted it automated, I don't think it'd be too hard to create a colours.d2l.dev repo and site, and have the automation check out core and run the scripts. It likely couldn't/shouldn't check out the LMS though. 🤔

Edit to add: And even if it was to remain manual, I don't think a dedicate live site would be that much work

I think at this point it's fine to be manual. There aren't plans/requirements to re-run on any sort of regular basis. We could also have some be manual (e.g., lms) and some automated (e.g., core). I think the colours.d2l.dev repo/site probably makes the most sense.

margaree avatar Nov 21 '25 17:11 margaree

Yesterday we spoke briefly about other properties that we might want included from a broader theming perspective. We might consider tweaking this a bit for the more general "theme" case.

I have a separate story for adding in the other properties, but yeah the page currently is very specific for colours. I'll work on generalizing it more.

margaree avatar Nov 21 '25 17:11 margaree

Yesterday we spoke briefly about other properties that we might want included from a broader theming perspective. We might consider tweaking this a bit for the more general "theme" case.

I have a separate story for adding in the other properties, but yeah the page currently is very specific for colours. I'll work on generalizing it more.

Yeah, so given that probably not colours.d2l.dev, maybe daylight-semantics.d2l.dev or something

svanherk avatar Nov 21 '25 18:11 svanherk

Pushing changes so everything is in one place and up to date, but no need for a formal review/approval; I'll be making a fresh repo

margaree avatar Nov 24 '25 17:11 margaree