core icon indicating copy to clipboard operation
core copied to clipboard

WIP - Update d2l-tooltip to use PopoverMixin

Open dbatiste opened this issue 11 months ago • 1 comments

GAUD-7355

This PR is a work in progress. It defines a new class for d2l-tooltip that extends PopoverMixin. Most of the opener behaviour is duplicated from the original, but I've taken the opportunity to convert the members to actually be private. PopoverMixin basically replaces all the original tooltip positioning logic.

Currently it simply displays the tooltip using PopoverMixin but there is remaining work:

  • Adapting the complete d2l-tooltip API positioning options
  • Applying style overrides to the popover so it looks the same as tooltips (ex. dark background)

The original code is unchanged with the exception of factoring out a couple helper methods.

I will add some comments to the PR to help review.

Flagged (off) with GAUD-7355-tooltip-popover.

image

dbatiste avatar May 02 '25 20:05 dbatiste

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5640/

[!NOTE] The build needs to finish before your changes are deployed. Changes to the PR will automatically update the instance.

github-actions[bot] avatar May 02 '25 20:05 github-actions[bot]

:tada: This PR is included in version 3.144.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: