core icon indicating copy to clipboard operation
core copied to clipboard

[d2l-meter] property for hiding text

Open abcotter opened this issue 1 year ago • 1 comments

Context

  • circle meter took in a text property like the radial meter, however it only assigned it to the aria text. We'd like the circle meter to be able to behave similarly to the radial meter
  • https://d2l.slack.com/archives/C0PHG3QB0/p1712758381367159

Implementation Details

  • add text-hidden prop to meter-mixin
  • begin using the new prop to dynamically inject text beneath the circle meter

abcotter avatar Apr 10 '24 17:04 abcotter

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-4587/

[!NOTE] The build needs to finish before your changes are deployed. Changes to the PR will automatically update the instance.

github-actions[bot] avatar Apr 10 '24 18:04 github-actions[bot]

Any objection if we close this PR?

dbatiste avatar Jul 04 '24 13:07 dbatiste

Closing. We can revisit this in the future if required.

dbatiste avatar Jul 04 '24 13:07 dbatiste