rcv icon indicating copy to clipboard operation
rcv copied to clipboard

new GUI modal: tabulation confirmation page

Open artoonie opened this issue 2 years ago • 4 comments

closes #679

  • Creates new GUI Tabulation Dialog (see corresponding issue)
  • Has a check to make sure the # of ballots didn't change between "Check Ballot Count" and "Tabulate."
  • Extensible so we can later has the entirety of the CVRs and check that there was no change whatsoever, not just in ballot counts
  • Extensible so we can pull additional metadata and show on the GUI before hitting tabulate

artoonie avatar Mar 23 '24 22:03 artoonie

Two things I noticed while looking over this

  • The progress bar hangs during tabulation. It starts out moving, then at some point during tabulation hangs. Here's a video.
  • Each run of tabulate takes a little bit longer than the previous one. Here's some splits I did with the Minneapolis Mayor test data. It got about 5 seconds longer each time I ran it. Not the end of the world, but might be worth looking into... image

yezr avatar May 08 '24 15:05 yezr

Good catch! Both of these are present in 1.3.2 as well, though I agree this PR makes them more evident (especially the GUI lag).

I'll tackle the increase in timing first, then look at the GUI freezing. Since both exist outside of this PR, it may be useful to have separate tickets for them? But not super necessary.

artoonie avatar May 08 '24 19:05 artoonie

I'll make new tickets. A P0 for the UI hanging #830. A P2 for the increased duration on consecutive runs #831

yezr avatar May 08 '24 19:05 yezr

Turns out both had the same underlying cause, and both are fixed in #832

artoonie avatar May 08 '24 22:05 artoonie

can we make the Number of Ballots number formatted with commas on the thousands like 1,000 or 1,000,000

yezr avatar Jun 03 '24 23:06 yezr

can we make the Number of Ballots number formatted with commas on the thousands like 1,000 or 1,000,000

Sure, I'll handle this in my nit-handling commit shortly.

HEdingfield avatar Jun 04 '24 00:06 HEdingfield

Done!

artoonie avatar Jun 04 '24 02:06 artoonie