Brian Sun

Results 28 comments of Brian Sun

> Thanks! There are several conflicts. So, can you fix them? Then, we'll have another round of reviews. > > I really want to merge this PR. So, let's work...

> Thanks! There are several conflicts. So, can you fix them? Then, we'll have another round of reviews. > > I really want to merge this PR. So, let's work...

Hi Shinji @sw005320. I have written some unittest for my newly added code, but they failed because "warp-rnnt" is not installed. I noticed that the current version of ESPNet does...

> We are using https://github.com/espnet/espnet/blob/master/tools/installers/install_warp-transducer.sh#L29, which will be installed in our normal CI configuration in https://github.com/espnet/espnet/blob/master/ci/install.sh#L24 Can. you double-check it? Hi Shinji. Yes, I understand that `warp-transducer` is used. However,...

> Hi, > > > @b-flo, do you think we can update the interface to support it in warp-transducer? > > Sure, let me take a look later this week....

> > Actually the implementation currently is only for ASRTask with transducer model. > > Got it sorry, the decoder and joint network are shared across version. I thought I...

Thank you for the question. Video-SALMONN is trained with vicuna-13b so the input dimension for the 7b model would not match the Q-Former output of video-SALMONN. It would be helpful...

Thank you for pointing this out! We have included `requirements.txt` file where you can install packages there that are sufficient to run inference. Please let me know if you have...