HEMTT icon indicating copy to clipboard operation
HEMTT copied to clipboard

Windows build doesn't print git hash on `--version`

Open jonpas opened this issue 6 years ago • 6 comments

HEMTT Version: 0.7.4 Project: N/A

Description:

  • hemtt.exe --version -> HEMTT 0.7.3
  • ./hemtt --version -> HEMTT 0.7.3-8df045f
  • 0.7.3 because version was never bumped to 0.7.4 on release.

Steps to reproduce:

  • Run HEMTT with --version

Additional information:

/

HEMTT Output:

/

jonpas avatar Feb 11 '20 15:02 jonpas

Looks like GIT_HASH environment variable just isn't set for Windows compilation, ref.: https://github.com/synixebrett/HEMTT/blob/master/src/lib.rs#L40

jonpas avatar Feb 12 '20 01:02 jonpas

Unable to reproduce on Windows, were you using CI builds or locally built?

BrettMayson avatar Apr 02 '20 16:04 BrettMayson

That one was a CI build. CI doesn't read the hash as per my last comment.

jonpas avatar Apr 02 '20 16:04 jonpas

image

Tried it with the latest windows builds

Seems there is a different bug, AppVeyor has it twice...

BrettMayson avatar Apr 02 '20 16:04 BrettMayson

Can reproduce the same way, not the original bug with 0.7.5. Maybe it was fixed in CI at some point (addition of GitHub Actions?), but this was introduced.

jonpas avatar Apr 02 '20 16:04 jonpas

Yeah not sure, nothing has changed in the CI jobs since this issue was created

BrettMayson avatar Apr 02 '20 17:04 BrettMayson

Closed with 1.0.0, outdated issue

BrettMayson avatar Mar 16 '23 04:03 BrettMayson