lichocker icon indicating copy to clipboard operation
lichocker copied to clipboard

Represent lichess as a compose container stack

Open gmolaire opened this issue 5 years ago • 6 comments

  • Cleanup of unnecessary files
  • Decoupling of mongodb and redis as separate services
  • Use a base container containing the necessary build tools for lila and lila-ws
  • Update the README to match the changes

#15

gmolaire avatar Aug 08 '20 16:08 gmolaire

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.

Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile I think it should be added to the Dockerfile 👍

kraktus avatar Sep 03 '20 18:09 kraktus

Overhaul I'd like to say this looks very nice! Also well documented PR.

kraktus avatar Sep 03 '20 19:09 kraktus

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.

Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile I think it should be added to the Dockerfile

I understand your idea. The whole point though is to not reinvent the wheel. If someone is uncomfortable, (s)he can re-generate the image locally with its own settings.

gmolaire avatar Sep 19 '20 17:09 gmolaire

This is much cleaner and easier to understand. Prior to this I was uncomfortable with the existence of many scripts like build/node-init.sh and build/sdkman-init.sh which appeared unnecessarily complex to me since I never had to use them to setup my own lila development environment per instructions.

RogerThiede avatar Dec 22 '20 01:12 RogerThiede

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools.

Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile I think it should be added to the Dockerfile 👍

@gmolaire Wouldn't it be more appropriate to include those images in the same repository? I agree that it would be good to keep this self-contained and not depend on an external image.

BrandonE avatar Jan 18 '21 19:01 BrandonE

Why remove the Dockerfile? Some people don't want to trust/depend on a external image such as gmolaire/lila-build-tools. Edit: found that https://github.com/gmolaire/lila-docker-build-tools and https://github.com/gmolaire/docker-sbt/blob/master/Dockerfile I think it should be added to the Dockerfile +1

@gmolaire Wouldn't it be more appropriate to include those images in the same repository? I agree that it would be good to keep this self-contained and not depend on an external image.

I don't think security is the real concern nor isolation, but I do see a potential need for the build tools to change and make the external images become irrelevant. I will adjust to allow the compose to start from build tools generated locally.

gmolaire avatar Jan 22 '21 18:01 gmolaire