CommandShop icon indicating copy to clipboard operation
CommandShop copied to clipboard

CommandShopUI!!

Open nasiridrishi opened this issue 8 years ago • 19 comments

Brief description

Its not an issue but it would be awesome if you can dev it as UI based command shop!!

Steps to reproduce

  1. ...
  2. ...
  3. ...

Expected result

Actual result

Server Information

  • CommandShop Version:
  • Software Version:
  • Server OS:

CrashDumps/Errors

Paste your CrashDump or error by replacing this text (DON'T delete the backticks!)

nasiridrishi avatar Nov 22 '17 06:11 nasiridrishi

You aren't the first with that idea, but I'll be waiting for PMMP's integrated to be merged to master

HimbeersaftLP avatar Nov 22 '17 06:11 HimbeersaftLP

Actually, I'll try to start teaching the BOD team how to efficiently make UIs. This isn't too hard to do.

AvgZing avatar Nov 22 '17 12:11 AvgZing

@TheRoyalBlock I know you can directly use JSON, but I'd rather use the API because we won't have to change that much if MCPE changes the format.

HimbeersaftLP avatar Nov 22 '17 13:11 HimbeersaftLP

Erm.... There is an API...

AvgZing avatar Nov 22 '17 16:11 AvgZing

Nope

HimbeersaftLP avatar Nov 22 '17 17:11 HimbeersaftLP

https://github.com/pmmp/PocketMine-MP/pull/1476 Still W.I.P.

HimbeersaftLP avatar Nov 22 '17 17:11 HimbeersaftLP

It's possible to make a UI https://github.com/thebigsmileXD/WarpUI https://github.com/PlexusStudio/WorldTpUI

AvgZing avatar Nov 22 '17 17:11 AvgZing

The first one uses a nonexistent function on a Player object (probably made for a fork?) The second one uses a super complicated method to do it manually (as I said above you can directly use JSON)

HimbeersaftLP avatar Nov 22 '17 17:11 HimbeersaftLP

The WorldTpUI one is not complicated, I can explain it.

AvgZing avatar Nov 22 '17 17:11 AvgZing

And the second one uses both of these:

https://github.com/thebigsmileXD/customui https://github.com/thebigsmileXD/WarpUI

AvgZing avatar Nov 22 '17 17:11 AvgZing

The WorldTpUI one is not complicated, I can explain it.

I know how it works, it's just a lot of code which wouldn't be needed of we could use a builtin API and that has to be updated every time Mojang decides to change something.

HimbeersaftLP avatar Nov 22 '17 17:11 HimbeersaftLP

Mojang changes it less frequently than Pocketmine does, and we already update this plugin every time pocketmine changes

AvgZing avatar Nov 22 '17 17:11 AvgZing

How about we just make our code for the unfinished API? It's surely not going to take a decade for that PR to get merged.

Mojang changes it less frequently than Pocketmine does

*cough* *cough*

HimbeersaftLP avatar Nov 22 '17 17:11 HimbeersaftLP

I'm not so sure about that... Many PM PRs take weeks or even months... But good idea!

AvgZing avatar Nov 22 '17 17:11 AvgZing

Even if we knew it will take months, we could just make the base plugin, and if the pr still isn't merged, it isn't that hard to add our own UI implementation. So, should CommandShopUI be a seperate plugin?

HimbeersaftLP avatar Nov 22 '17 17:11 HimbeersaftLP

Yea

AvgZing avatar Nov 22 '17 17:11 AvgZing

lol yeah

Artistic-Waffle avatar Dec 10 '17 15:12 Artistic-Waffle

???? news?

LeoBdt avatar May 03 '19 21:05 LeoBdt

When the rewrite is finished, making a CommandShopUI plugin that uses the new CommandShop API should be fairly easy.

HimbeersaftLP avatar May 03 '19 21:05 HimbeersaftLP