Throw a KeyError exception if obsolete names are used
Unlike #187, this version no longer supports obsolete names. Instead, it returns an exception, compelling the user to switch to the latest version.
The names are passed directly to the constructor, eliminating the need for additional files or constants. This allows for the identification of names from previous versions without the need to execute the code.
Fixes #168. Replaces #171 and #187.
Coverage Report
File Stmts Miss Cover Missing luxtronik __init__.py 184 11 94% 42–43, 46–51, 257–258, 263 __main__.py 21 21 0% 3–49 datatypes.py 322 1 99% 110 discover.py 58 1 98% 62 luxtronik/scripts dump_changes.py 43 43 0% 7–85 dump_luxtronik.py 26 26 0% 6–52 luxtronik/shi definitions.py 204 3 99% 113, 425–426 modbus.py 105 1 99% 320 TOTAL 1144 107 91%
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 237 | 0 :zzz: | 0 :x: | 0 :fire: | 15.676s :stopwatch: |
@Bouni, @gerw How do you like this proposed solution?
For me this seems reasonable and since its configurable, it should make everyone happy. Anyone against merging this, since it has been lying around for quite a while?
LGTM
@kbabioch Feel free to merge this one
I've rebased it on top current master and self-approved it, since this was a trivial change. Hopefully no one feels offended by this, wanted to proceed with this one, since @Bouni told us that we may proceed in this previous comment.