iOS-UtiliKit icon indicating copy to clipboard operation
iOS-UtiliKit copied to clipboard

External Map Deeplinks

Open br-nchiu opened this issue 3 years ago • 2 comments

New pull request to resolve merge conflicts

br-nchiu avatar Apr 12 '22 16:04 br-nchiu

I'd be interested to hear other's thoughts on this - but I don't think this belongs in UtiliKit. The times a user would need something like this is much more infrequent than view controller configuration, or collection view usage, etc.

That isn't to say I don't think this is valuable to have, I'd just much rather see this be a standalone swift package or Cocoapod that is fully geared toward Map URL building.

Agreed, I think "All the things you're tired of writing." is a bit too broad and is making this a catch all. There are several pieces that might be better as stand alone swift packages- external maps deeplinks, scrolling page control (deprecated), active labels, etc- pretty much anything that isn't a broad use case extension of a type found in Foundation/UIKit/SwiftUI.

br-nchiu avatar Apr 19 '22 15:04 br-nchiu

I could see this being its own separate repo/package. Really, we should probably extract a bunch of stuff out of UtiliKit per @br-nchiu's point. The other option would be to continue to push code here, but utilize subspecs to allow clients to only pull in the functionality they're interested in.

br-tyler-milner avatar May 05 '22 15:05 br-tyler-milner