BEMSimpleLineGraph icon indicating copy to clipboard operation
BEMSimpleLineGraph copied to clipboard

Swift conflicts with deprecated protocol methods

Open AvdLee opened this issue 9 years ago • 1 comments

screen shot 2016-05-04 at 09 15 32

This result in an annoying error, which can be fixed by implementing the datasource callback as followed:

func lineGraph(graph: BEMSimpleLineGraphView, labelOnXAxisForIndex index: Int) -> String

AvdLee avatar May 04 '16 07:05 AvdLee

It looks like the lineGraph:labelOnXAxisForIndex: was originally implemented on BEMSimpleLineGraphDelegate, but is now implemented on BEMSimpleLineGraphDataSource.

This issue has been reported previously and is fixed on the feature branch in commit 83e8acd7efa4657258c1320442d5f59953bdc710. Duplicate of #214.

The feature branch has not yet been merged due to breaking changes that need to be tested and announced. If it's not too difficult for your workflow, I would recommend adopting these changes.

Sam-Spencer avatar Jul 02 '16 20:07 Sam-Spencer