BookStack icon indicating copy to clipboard operation
BookStack copied to clipboard

Assess if we can avoid putenv usage to avoid some thread safety issues

Open ssddanbrown opened this issue 1 year ago • 0 comments

In thread error-prone environments (Apache on XAMPP windows by default for example) there can be issues with things like config loading, where config ends up blank.

This can be helped by config caching as a workaround, which we don't advise/document, but I feel it's better to avoid such thread problematic scenarios completely where possible, which it looks like it may be:

https://github.com/laravel/framework/pull/28908 https://github.com/laravel/framework/pull/28740

From what I can tell, this could effect libraries that use putenv/getenv, so might need to think-about/audit potential impacts there.

ssddanbrown avatar Jul 17 '24 09:07 ssddanbrown