BookStack icon indicating copy to clipboard operation
BookStack copied to clipboard

Non PSR-4 compliant test class namespace

Open LordSimal opened this issue 1 year ago • 0 comments

Describe the Bug

After a composer install command it shows the following warnings:

Class Activity\WebhookCallTest located in ./tests/Activity/WebhookCallTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\WebhookFormatTesting located in ./tests/Activity/WebhookFormatTesting.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\AuditLogApiTest located in ./tests/Activity/AuditLogApiTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\WebhookManagementTest located in ./tests/Activity/WebhookManagementTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\AuditLogTest located in ./tests/Activity/AuditLogTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.

Steps to Reproduce

  1. Download latest Bookstack (24.05.2 as of right now)
  2. perform a composer install with PHP 8.3 and composer 2.7.7

Expected Behaviour

No PSR autoloading warnings on composer install

Screenshots or Additional Context

This can be fixed rather easily by adjusting the namespace of e.g. tests/Activity/WebhookCallTest.php (and all other files from above) from

namespace Activity;

to

namespace Tests\Activity;

since the Tests namesapce is defined in the composer.json

Browser Details

No response

Exact BookStack Version

24.05.2

LordSimal avatar Jun 17 '24 12:06 LordSimal