Cover images inconsistent

[steven-loscheider]

Describe the Bug

The cover images for shelves and books are not consistent. The Edit menu suggests : "This image should be approx 440x250px."

Images are cut off or have the wrong aspect ratio when uploaded. The corporate branded images I have used with exactly 440x250 px are cut off or have different aspect ratio than the original file. So it is difficult to create a coherent look.

Steps to Reproduce

Edit a shelf or book and add a cover image with the recommended size of 440x250px. If you refresh the shelf or book page, the image will not be displayed correctly as you created it.

Expected Behaviour

Image will be used 1:1 as uploaded. Required aspect ratio and image resolution are defined in the edit menu before uploading The original image will be used on all subsequent pages

Example to illustrate (with a realistic 250x150px image size):

• Image requirements in the edit menu indicate 250x150 px image to be uploaded.
• User generates and uploads 250x150 px image to bookstack.
• Original image will be used on all subsequent pages. No cutting, stretching or resizing is performed.
• Image looks as intended on all pages.

Screenshots or Additional Context

No response

Browser Details

Firefox 120.0.1

Exact BookStack Version

23.10.4

[ssddanbrown]

Hi @steven-loscheider, The mentioned size is really just a rough guide for something of sensible size. At no point do we promise or indicate the image will be used as per its exact original size, nor would I want to indicate/promise/support that really, since the size and aspect ratio of the area the image is used for will change in a flexible manner depending on a number of factors so suit the design.

[szabeszg]

I recommend changing the wording so that it more accurately aligns with the intended concept. Something like: "The recommended image size is approximately 440x250 pixels. It is advisable to test beforehand to determine what suits you best."

[steven-loscheider]

Hi @ssddanbrown I see. Maybe change the wording on the edit page as @szabeszg suggested to avoid any confusion. In the meantime I will rework the graphics and add some margin to make them appear properly even if they get cut off here or there.

[ssddanbrown]

Thanks for the input. I've now updated the wording in 16327cf40cbc98d549a222d48c844eb8b3bc7bdc, to better hint about the flexibility of the dimensions in use. This will be part of the next feature release.