Jing Kan

Results 39 comments of Jing Kan

JD.com selling it as "米家空调伴侣2", but acutally, the model is: lumi.acpartner.mcn02 And current plugin is not supporint that : (

Awesome work! I met same issue and I have to wrap a git.exe and use git log to speed up the log reading.

> @Blueve Could you share your code for parsing the git.exe output? We read the cmd output from git log command, such as: `git --no-pager log --date-order --no-merges --no-renames --pretty=format:@/%H/...

> Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly. Why you state that you tested on 7250?

Should this be a part of doc: https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md ?

Comments from community: 1. Support different format for start_time and end_time (might be we can do this in cli's implementation ) 2. Add optional field to existing acl rule instead...

Can you update this file instead? https://github.com/sonic-net/sonic-mgmt/blob/8b16ae88185658d2d537299e8f5b6f546a992596/tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml#L749

@nhe-NV can you help backport this fix to 202012 and 202205? The conditional mark was backported to 202012 branch but all these tests are failed due to the issue closed....

Thanks @nhe-NV ! I added backport labels and expect they can been cherry-picked in recent days. If they cannot be clean merged, I will let you know.