CoreNeuron icon indicating copy to clipboard operation
CoreNeuron copied to clipboard

Give possibility to change mpiexec configuration for integration tests

Open alkino opened this issue 4 years ago • 8 comments

Some mpiexec version does not have the option -n, so it should be configurable

alkino avatar Nov 29 '21 14:11 alkino

@alkino : could you check failing CI?

pramodk avatar Dec 20 '21 16:12 pramodk

Codecov Report

Merging #699 (93a6567) into master (7b0b6d9) will decrease coverage by 2.02%. The diff coverage is n/a.

:exclamation: Current head 93a6567 differs from pull request most recent head 7295f4a. Consider uploading reports for the commit 7295f4a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   55.51%   53.49%   -2.03%     
==========================================
  Files         107      107              
  Lines        8947     8947              
==========================================
- Hits         4967     4786     -181     
- Misses       3980     4161     +181     
Impacted Files Coverage Δ
coreneuron/network/multisend_setup.cpp 44.48% <0.00%> (-30.52%) :arrow_down:
coreneuron/network/multisend.cpp 42.50% <0.00%> (-19.00%) :arrow_down:
coreneuron/mpi/lib/mpispike.cpp 58.82% <0.00%> (-5.89%) :arrow_down:
coreneuron/utils/progressbar/progressbar.cpp 82.95% <0.00%> (-5.69%) :arrow_down:
coreneuron/io/nrn_setup.cpp 82.15% <0.00%> (-3.54%) :arrow_down:
coreneuron/network/netcon.hpp 51.61% <0.00%> (-3.23%) :arrow_down:
coreneuron/network/netcvode.cpp 71.24% <0.00%> (-2.88%) :arrow_down:
coreneuron/network/partrans.cpp 93.02% <0.00%> (-2.33%) :arrow_down:
coreneuron/io/output_spikes.cpp 87.50% <0.00%> (-1.48%) :arrow_down:
coreneuron/sim/fadvance_core.cpp 82.82% <0.00%> (-0.62%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b0b6d9...7295f4a. Read the comment docs.

codecov-commenter avatar Dec 21 '21 16:12 codecov-commenter

@alkino : converting this to draft until CI is fixed. If you think this is not relevant now, feel free to close this.

pramodk avatar Mar 02 '22 12:03 pramodk