s2client-api icon indicating copy to clipboard operation
s2client-api copied to clipboard

Add install target for Linux and Mac

Open kuzi117 opened this issue 8 years ago • 6 comments

This addresses #90.

Some tldr to begin:

  • This isn't perfect.
  • It doesn't support Windows (very well).
  • There are a few problems that I've addressed in #90 with exporting targets. People who are manually linking against this won't have a problem, people who are using cmake may be irritated.
  • Updates must be made to both civetweb and protobuff before accepting this.

I've addressed all of this fairly in depth in #90 except for maybe Windows support. It does build and it does install, but I'm just not sure it does them well. I can explain more if necessary.

Civetweb needs to pull in the changes I made to allow disabling compiling the executable (PR and merge commit).

Protobuf needs to be brought up to date with at least this commit.

I haven't actively touched this in a while. I did recompile both this fork and my project that used it as a target and they both worked so I can confirm this works for at least Ubuntu. I expect it to still be working on Mac but if someone wants to confirm for me, please be my guest. I'll answer any other questions as I can.

kuzi117 avatar Nov 25 '17 05:11 kuzi117

Scratch that. I need to do some updates apparently. I'll leave this here as a promise to get it updated soon.

kuzi117 avatar Nov 25 '17 05:11 kuzi117

Found and fixed. Hopefully there's no more hiccups.

kuzi117 avatar Nov 25 '17 06:11 kuzi117

This is a bit to review; I'll look into it later today. Thank you! Sorry for the delayed response, things have been busy on our end.

AnthonyBrunasso avatar Nov 29 '17 17:11 AnthonyBrunasso

Honestly, it's been more delayed from my end, just sitting there for a couple months, so I can hardly blame you. It might be worth looking at #90 partly to understand some of the issues that are present in this (and would be in any similar pull request) and partly just because it's been there a while.

kuzi117 avatar Nov 29 '17 18:11 kuzi117

@AnthonyBrunasso any progress on this?

herodrigues avatar Apr 01 '18 03:04 herodrigues

I'll check in on this failure soon.

kuzi117 avatar Apr 14 '18 06:04 kuzi117