node-rdkafka icon indicating copy to clipboard operation
node-rdkafka copied to clipboard

Allow passing null to commitSync in KafkaConsumer typings

Open Tapppi opened this issue 1 year ago • 0 comments

In the typings KafkaConsumer incorrectly requires that commitSync be called with a TopicPartitionOffset or an array of TopicPartitionOffsets, when docs say that null can be passed to commit all read offsets. This change allows null to be passed without resorting to hacks like client.commitSync(null as any).

Tapppi avatar Jun 25 '24 21:06 Tapppi