startbootstrap icon indicating copy to clipboard operation
startbootstrap copied to clipboard

Add viminfo parser

Open sydp opened this issue 3 years ago • 6 comments

One line description of pull request

This PR adds a new parser for a viminfo file.

Description:

Fixes #4109

Checklist:

  • [x] Automated checks (Travis, Codecov, Codefactor )pass
  • [x] No new new dependencies are required or l2tdevtools has been updated
  • [ ] Reviewer assigned

sydp avatar Jun 19 '22 14:06 sydp

Codecov Report

Base: 85.75% // Head: 85.66% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (b77ba3a) compared to base (d790101). Patch coverage: 83.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4142      +/-   ##
==========================================
- Coverage   85.75%   85.66%   -0.09%     
==========================================
  Files         399      403       +4     
  Lines       34038    34645     +607     
==========================================
+ Hits        29188    29679     +491     
- Misses       4850     4966     +116     
Impacted Files Coverage Δ
plaso/parsers/viminfo.py 83.50% <83.50%> (ø)
plaso/output/winevt_rc.py 63.10% <0.00%> (-1.88%) :arrow_down:
plaso/parsers/esedb_plugins/interface.py 62.14% <0.00%> (-1.50%) :arrow_down:
plaso/output/mediator.py 70.54% <0.00%> (-0.98%) :arrow_down:
plaso/lib/definitions.py 100.00% <0.00%> (ø)
plaso/formatters/chrome.py 100.00% <0.00%> (ø)
plaso/formatters/msiecf.py 100.00% <0.00%> (ø)
plaso/formatters/winlnk.py 100.00% <0.00%> (ø)
plaso/formatters/winreg.py 100.00% <0.00%> (ø)
plaso/formatters/default.py 62.50% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 20 '22 04:06 codecov[bot]

AppVeyor build failed - "Build execution time has reached the maximum allowed time for your plan (60 minutes)."

sydp avatar Jun 22 '22 08:06 sydp

@sydp is this ready for review?

joachimmetz avatar Jul 09 '22 09:07 joachimmetz

@sydp what is the status of this?

joachimmetz avatar Aug 06 '22 06:08 joachimmetz

@sydp what is the status of this?

ready for review thanks @joachimmetz

sydp avatar Aug 06 '22 06:08 sydp

@sydp please merge the 2 separate parser classed and use one of the text parser base classes

joachimmetz avatar Aug 09 '22 04:08 joachimmetz

@sydp did something go wrong?

joachimmetz avatar Sep 11 '22 08:09 joachimmetz

hmm yes i just tried to sync my branch.

sydp avatar Sep 11 '22 09:09 sydp