Footer

[Selasi3]

[kjaymiller]

Thank you for this PR

One thing I would request from you in the future is that you provide a description for the PR as it helps to quickly figure out what the issue was and what the solution is. This isn't for the reviewer but also to provide some context in the future for someone that may want to make an informed change.

[kjaymiller]

@Selasi3 - I'm noticing an issue here that I think may be git related.

Your footer changes were added at one point and removed in the commit history.

You may want to take a look (also this could have been discovered with writing a test for this.)

I cannot approve this PR until the following things happen.

• [ ] Return Footer Code to the Codebase (you can try to do a reset to the commit where the footer content was added and perform a partial add of the footer). Or if you have the code reapply it. (The code will get squashed down anyway)
• [ ] Create a test that ensures the pages that we want are added into the footer. - You can do this with playwright which we are using.

[Selasi3]

Hello Sir,

Please I have made the changes and requested a pull request.

Thank you.

Kind regards.

On Tue, Oct 1, 2024 at 4:44 PM Jay Miller @.***> wrote:

@Selasi3 https://github.com/Selasi3 - I'm noticing an issue here that I think may be git related.

Your footer changes were added at one point and removed in the commit history.

You may want to take a look (also this could have been discovered with writing a test for this.)

I cannot approve this PR until the following things happen.

• Return Footer Code to the Codebase (you can try to do a reset to the commit where the footer content was added and perform a partial add of the footer). Or if you have the code reapply it. (The code will get squashed down anyway)
• Create a test that ensures the pages that we want are added into the footer. - You can do this with playwright which we are using.

— Reply to this email directly, view it on GitHub https://github.com/BlackPythonDevs/blackpythondevs.github.io/pull/494#issuecomment-2386493068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQLYWNSM3ETOBXPYXKMXNTZZLGNBAVCNFSM6AAAAABPFCJCTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBWGQ4TGMBWHA . You are receiving this because you were mentioned.Message ID: @.*** com>

-- Ayittah Selasi Randy Tel. no: 0541272429

[kjaymiller]

Closing this as it's been 3 weeks with no response to the request.