PyBitmessage icon indicating copy to clipboard operation
PyBitmessage copied to clipboard

Refactor using of crypto functions

Open g1itch opened this issue 4 years ago • 2 comments

In this branch I'm gonna cover by tests all the crypto functions used in code and do a refactoring. Basic points:

  • only highlevelcrypto should import from pyelliptic
  • highlevelcrypto should not depend on the app state e.g. module state or BMConfigparser() instance (the same will be done for protocol in #1788)
  • highlevelcrypto should include hashes - double sha512, ripemd160
  • finally I'm gonna detach pyelliptic into the separate repo to show a possible way of addressing #886

g1itch avatar Jul 28 '21 21:07 g1itch

overall nice work, although I haven't investigated it in depth

PeterSurda avatar Nov 15 '21 07:11 PeterSurda

overall nice work, although I haven't investigated it in depth

It seems that I misplaced (or misnamed) the signatures. I was going to regenerate them. And there is also a lot of unfinished changes here, mentioned in the PR description.

g1itch avatar Nov 15 '21 12:11 g1itch