Bitmessage
UI refactoring, part 2
Hello!
In the second part of UI refactoring I moved most of widgets definitions into ui-files, removed autogenerated code and renamed bitmessageui to main.
Minor appearance differences include:
- Add buttons are not resizing infinitely
- ~~UPnP checkbox label on tab "Network Settings" of Settings dialog~~
- ~~"Resends expire tab" of Settings dialog.~~
Also maybe I did wrong in retranslateui.
These changes definitely require testing. I'm going to write some soon. ~~But it may make sense to merge this before qt5-wip because of many pylint warnings in obsolete settings and bitmessageui modules.~~
Man this is huge. Does it affect the translation sources? Transifex could delete parts of old translations if they move to a different context.
It looks ok but I'm not going to review it in detail. I checked translation compiling, and that looks like it doesn't break it. There is one major problem though, when I try to run it, the main window briefly pops up and then it crashes:
Loading existing config files from /home/bitmessage/.config/PyBitmessage/
Gtk-Message: Failed to load module "canberra-gtk-module"
2018-11-19 13:36:25 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated
2018-11-19 13:36:25 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button
2018-11-19 13:36:25 MainThread __init__.py@965 No indicator plugin found
2018-11-19 13:36:25 MainThread __init__.py@985 No notification.message plugin found
2018-11-19 13:36:30 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated
2018-11-19 13:36:30 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button
Segmentation fault
No, I guess about a half of translations strings will be reset by this changes.