BitcoinDesign
Contribute page review structure & checklist
I complained a bit yesterday about some common issues I find across PR reviews, and Yashraj recommended creating a checklist. So here it is.
This PR expands on the process for requesting reviews and proposes a 3-step structure. It also adds a common issues checklist for general and smaller things to look out for before requesting reviews.
I am keeping this as a draft as I'd like to share it for now, but also do another iteration specifically looking out for cross-linking and referencing across other pages in the contribute section. Also curious to hear if others have items they'd like to put on the checklist.
Deploy Preview for bitcoin-design-site ready!
| Name | Link |
|---|---|
| Latest commit | 3b3e257aab97ecb01016d82dea92929d11a14757 |
| Latest deploy log | https://app.netlify.com/sites/bitcoin-design-site/deploys/6731f9a645f9430008e8b5fb |
| Deploy Preview | https://deploy-preview-1117--bitcoin-design-site.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Sorry the following is feedback for the page/topic in general and not limited to this PR
I also wonder how much GitHub must be a part of 'proposing a change'. Much of the content here is likely to be applicable whether or not somebody opens a PR. It can also be a steep learning curve for non-technical people, and I'd figure we want to make this process as accessible as possible.
If the above makes sense, perhaps the checklist might appear somewhere else maybe higher up on the page but possibly more changes needed then...
