MikaLendingBot icon indicating copy to clipboard operation
MikaLendingBot copied to clipboard

Rates statistic

Open maroun2 opened this issue 6 years ago • 1 comments

Description

It adds a plugin with rates statistic. It seems that someone wants this future also #312 It's my first pull request, so please excuse my mistakes. Preview: https://ibb.co/TPKM8ZJ

TESTING STAGE

It was tested. This functionality is separated from lending functionality.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] I have read CONTRIBUTING.md
  • [x] I fully understand Github Flow.
  • [x] My code adheres to the code style of this project.
  • [ ] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
  • [x] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
  • [x] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

maroun2 avatar Jun 17 '19 06:06 maroun2

Currently: chart is based on the 24 hour schedule with multiple days stacked over each other.

This is useful if you are trying to look at the rates at certain times of day, otherwise I think it would be better to see the days linked end to end so you can see historical rates.

Maybe include a toggle between the modes or just set the default to the more intuitive mode (historical.)

Evanito avatar Jun 25 '19 01:06 Evanito