SyliusCmsPlugin icon indicating copy to clipboard operation
SyliusCmsPlugin copied to clipboard

provided ability for twig media tag to add optional template file string

Open porl opened this issue 5 years ago • 4 comments

Q A
Bug fix? no
New feature? yes
BC breaks?
Deprecations? no
License MIT

porl avatar Nov 05 '20 01:11 porl

Not sure if the test for null !== $template was strictly necessary

porl avatar Nov 05 '20 01:11 porl

Provide usage example, please.

leszczuu avatar Nov 19 '20 10:11 leszczuu

In my blocks/pages, I sometimes need to reference media files (usually images) but have them presented in a specific way. So In my block or template I would have:

{{ bitbag_cms_render_media('screenshot1', media/screenshot-card.html.twig) }}
{{ bitbag_cms_render_media('screenshot2', media/screenshot-card.html.twig) }}
{{ bitbag_cms_render_media('screenshot3', media/screenshot-card.html.twig) }}
{{ bitbag_cms_render_media('screenshot4', media/screenshot-card.html.twig) }}

instead of something like:

<div class="screenshot-card">
    {{ bitbag_cms_render_media('screenshot1') }}
</div>
<div class="screenshot-card">
    {{ bitbag_cms_render_media('screenshot2') }}
</div>
<div class="screenshot-card">
    {{ bitbag_cms_render_media('screenshot3') }}
</div>
<div class="screenshot-card">
    {{ bitbag_cms_render_media('screenshot4') }}
</div>

which is much easier to get messy (especially if an end-user is modifying page parts).

porl avatar Nov 21 '20 06:11 porl

This also brings the media render extension more into line with how the block render extension works.

porl avatar Nov 21 '20 06:11 porl

It seems like some changes had been made in RenderMediaExtension that already solved issue this PR is trying to solve. Due to that, closing.

MacBalc avatar Mar 10 '23 13:03 MacBalc