biotracker_core icon indicating copy to clipboard operation
biotracker_core copied to clipboard

Employ unified coding style

Open hmoenck opened this issue 8 years ago • 4 comments

Biotracker is using many different coding styles, mostly because developed by multiple people:

  • Header guards vs. pragma once
  • camel case vs ...
  • members: _ vs m_ vs nothing
  • indentation: spaces vs tabs
  • ...
  • private and public members policy Discuss here and employ a good style. Maybe use something like stylecop in VS to do so?

hmoenck avatar Sep 29 '17 09:09 hmoenck

Wasn't there an astyle git-hook already in use? I recall @Sh4kE was working on it like a year ago and at least on his system it seemed to be working.. If I remember correctly it even offered to 'automatically' standardize one's code upon commit/push. If this didn't make it to the workflow yet maybe it makes sense to reach out to Michael and ask him to share his implementation/configs.

jutanke avatar Oct 06 '17 12:10 jutanke

Yep, see:

  • https://github.com/BioroboticsLab/biotracker_core/blob/ff786c6ea6523a8badde7d07bd0b902ed1653da9/astyle/.astylerc
  • https://github.com/BioroboticsLab/biotracker_core/tree/ff786c6ea6523a8badde7d07bd0b902ed1653da9/githooks

Must have gotten lost in all the refactorings.

nebw avatar Oct 06 '17 12:10 nebw

I wasn't aware of that. Take a look here: 7d6495337939c0005552ada21cc32ba269624158 3037cc6db5247cf45235e25e9779c4c6fa34b903 7e0e5ff7f200352b5d91df2e9b56732782f8b5a3 Looks like they got skipped in the port to V3.

hmoenck avatar Oct 06 '17 12:10 hmoenck

Look who was a second faster than me :(

hmoenck avatar Oct 06 '17 12:10 hmoenck