deepali icon indicating copy to clipboard operation
deepali copied to clipboard

Optimisation of MI loss implementation

Open qiuhuaqi opened this issue 1 year ago • 1 comments

It has been noted by some collaborators that the MI implementation (here) in this library is slightly slower and less easy to tune than De Vos's implementation in TorchIR (https://github.com/BDdeVos/TorchIR/blob/main/torchir/metrics.py#L74). The TorchIR implementation also exposes the Parzen window width as a parameter for users to choose, while we automatically derive this from the choice of number of bins by setting the Gaussian kernel's FWHM as bin width. We could experiment with this as well.

This issue is to track experiments and optimisation.

qiuhuaqi avatar Mar 01 '24 11:03 qiuhuaqi

Thanks for relaying the feedback and helping to improve this! I've added TorchIO to the list of related projects.

aschuh-hf avatar Mar 07 '24 10:03 aschuh-hf