Capping icon indicating copy to clipboard operation
Capping copied to clipboard

feat(core): support dynamic click-through on bars based on configured modifier keys

Open VincentCassiau opened this issue 8 months ago • 3 comments

Adds the “click-through bars” functionality requested in Issue #130.

This pull request enhances the bar-click behaviour so that progress bars will only intercept mouse clicks when the user is holding a modifier key that is actually configured for click-handling. In all other cases the click “passes through” to whatever UI lies beneath the bar.

VincentCassiau avatar May 18 '25 13:05 VincentCassiau

This code would run continually even when not in a battleground, it would need to be changed.

funkydude avatar May 18 '25 16:05 funkydude

This code would run continually even when not in a battleground, it would need to be changed.

Thank you ! I’ve made the change, I’ll test it a bit more thoroughly to make sure it’s the right modification and didn't break anything, and then I’ll push it afterwards !

VincentCassiau avatar May 18 '25 19:05 VincentCassiau

I've just pushed new changes to address two issues:

  1. Added support for the "Test" mode that I had forgotten in my previous implementation
  2. Fixed the code that was running continually even when not in a battleground, as requested

Please note that I don't have a way to test these changes on BCC Vanilla and Wrath versions. If needed, I can remove the modifications for these versions and keep only the retail changes. Let me know what you prefer, and I'll adjust accordingly !

VincentCassiau avatar May 19 '25 12:05 VincentCassiau