Sieve icon indicating copy to clipboard operation
Sieve copied to clipboard

interface type fixes & unit test improvements

Open hasanmanzak opened this issue 3 years ago • 1 comments

Hi all,

It's been a long time, I know...

This fix is in my mind for a long time. Finally I got the time to actually do it!

Current implementation relies on IQueryable<T> where T is a concrete type. Sometime ago I did a change and put a very small workaround when sorts fail where T is an interface type!. This time, I did a complete rethinking about the problem and came up with this change.

This fix is final with one feature is consiously left out: Support for same property name for multiple interfaces. This version works for filters & orders, both.

I also did some editings to unit tests. I'm not completely happy with all that, but maybe sometime later, somebody can do a complete re-do to that area.

Be safe, all.

hasanmanzak avatar Feb 22 '23 22:02 hasanmanzak

@ITDancer13 @a-patel @Biarity @zolrath

Can anyone give a review and push this down to release?

hasanmanzak avatar Feb 23 '23 19:02 hasanmanzak