Sieve icon indicating copy to clipboard operation
Sieve copied to clipboard
verified publisher icon Biarity

Fix merge conflicts for: Let you choose the Culture used for TypeConversion in the processor #79

Open yannickdp opened this issue 5 years ago • 3 comments

Hi @a-patel,

I've made a new pull request in which I've redone the changes of @jonatanantoine (see #79). Can you please approve this and create a release? Thank you very much.

Yannick

yannickdp avatar Apr 27 '21 14:04 yannickdp

@yannickdp Please add/update unit test cases for this.

a-patel avatar Apr 27 '21 16:04 a-patel

@yannickdp Thanks for your contribution. There was a major fork merge lately. Can you please rebase your branch and change the target to releases/2.5.0 ? And please add/update unit test cases for this change as @a-patel suggested.

hasanmanzak avatar May 15 '21 13:05 hasanmanzak

I fixed the conflicts. Still needs unit tests, though.

@a-patel @ITDancer13 @Biarity ,

What do you think about this change?

LGTM, tests are available in https://github.com/Biarity/Sieve/pull/187/files

@yannickdp, can you take a look at the tests and move them to this PR?

ITDancer13 avatar Jul 14 '23 09:07 ITDancer13