BentoBox icon indicating copy to clipboard operation
BentoBox copied to clipboard

Hook into Dynmap

Open Poslovitch opened this issue 7 years ago • 44 comments

Is your feature request related to a problem? Please describe. ASkyBlock had a dynmap addon for it some time ago.

Describe the solution you'd like Provide a hook for Dynmap so that Gamemode addons can provide markers/layout for their world. Here is the API: DynmapCommonAPI.java.

Additional context We may have to provide some wrapper methods, but that'd overall be fine.

Poslovitch avatar Jan 18 '19 13:01 Poslovitch

This brings back memories!

tastybento avatar Jan 19 '19 03:01 tastybento

I've started to work on this - this is actually kinda easy, I'm impressed.

Poslovitch avatar Feb 08 '19 20:02 Poslovitch

Just so I don't lose time finding the code again, here's the direct link to ASkyBlock's dynmap hook: https://github.com/tastybento/dynmapASkyblock/blob/master/src/main/java/com/wasteofplastic/dynmap/DynmapASkyBlock.java

Poslovitch avatar Feb 09 '19 08:02 Poslovitch

Would be useful for displaying island warp signs as markers on the map.

TheWranger avatar Feb 16 '19 07:02 TheWranger

I might need to add that to the warp signs add on.

tastybento avatar Feb 16 '19 15:02 tastybento

I'll try to do an "API" in the DynmapHook ;)

Poslovitch avatar Feb 16 '19 16:02 Poslovitch

Postponing to 1.5.0 as this is not a high priority enhancement request.

Poslovitch avatar Mar 23 '19 20:03 Poslovitch

Working on that now :)

Poslovitch avatar Apr 11 '19 12:04 Poslovitch

Okay, so I got it working. image

However, I don't know what I should put on it right now :/

Poslovitch avatar Apr 13 '19 12:04 Poslovitch

Well. I'll be lazy and say that the purpose of this issue has been fulfilled. We'll see over time if people want every gamemode addon to display something by default. But shhhhhh!

Poslovitch avatar Apr 13 '19 12:04 Poslovitch

What's the actual status of this? I see the BSkyBlock toggle in the DynMap menu but nothing actually displays on the map.

Ownership/Name information about each island would be good.

ghost avatar Nov 27 '19 18:11 ghost

@Poslovitch Someone asked!

tastybento avatar Nov 27 '19 22:11 tastybento

What's the actual status of this? I see the BSkyBlock toggle in the DynMap menu but nothing actually displays on the map.

Ownership/Name information about each island would be good.

While the Hook is already there, its implementation has not been completed. Sorry for the inconvenience.

Poslovitch avatar Nov 30 '19 16:11 Poslovitch

Any eta when about we can expect this to be completed something like 1.9.1?

johncsuti avatar Dec 06 '19 23:12 johncsuti

It requires a more thoughtful planning than I thought it would. I'll work on this as a side thing, and see when it's ready.

Poslovitch avatar Dec 07 '19 16:12 Poslovitch

Can we hook this into borders as well and display a red border of stained glass to show the island protection range?

johncsuti avatar Jan 02 '20 02:01 johncsuti

Dynmap works great for the overworld is there a way to make it work in the end and nether? This is what i get in the nether the end it seems to work kinda but you can't zoom like you can on the overworld. Capture1

johncsuti avatar Jan 04 '20 03:01 johncsuti

Here is the end islands you can't zoom in more then this. Capture2

johncsuti avatar Jan 04 '20 03:01 johncsuti

Please fix this issue. The lack of Dynmap integration in BentoBox is severe for my server.

Status?

fnutt avatar Jan 05 '20 12:01 fnutt

@johncsuti I'm not sure I could do anything about the Nether and End dynmaps. I'm not doing anything related to them in the code, so that might be a dynmap issue (to be confirmed).

@fnutt I have tried locally a few different implementations to finish this feature. None of them were satisfying. I'll retry and try to get this done for 1.11.0.

Poslovitch avatar Jan 05 '20 17:01 Poslovitch

Well the major issue is the nether not showing anything. Is there a way to make the top of the nether see through so you can see the inside? Also to be confirmed as in your asking the author?

johncsuti avatar Jan 05 '20 20:01 johncsuti

I honestly don't know if hiding the nether roof would be possible. And yeah, I meant "to be confirmed" as in I am going to ask the author about it.

Poslovitch avatar Jan 05 '20 20:01 Poslovitch

Okay sounds like to me hiding the nether roof for skyblock would have to be built into dynmap. Not something you can code in unless the author allows you to code in a version of it into the addon.

johncsuti avatar Jan 05 '20 21:01 johncsuti

Doesn't dynmap have a 3d view? In that case, the roof doesn't show - or does it?

tastybento avatar Jan 08 '20 00:01 tastybento

3D doesn’t work on the nether it does work in the end with the same result as above. @tastybento you know my server ip you can also jump on my skyblock sever and register then go to dynmap.64stacks.com to login and check it out if you want.

johncsuti avatar Jan 08 '20 05:01 johncsuti

I suggest disabling map for Nether in Dynmap, @johncsuti. Regarding The End zooming, live with it! This is not an issue for BentoBox to solve.

If you really want hiding x-number of blocks from the top, or let yourself zoom further in on the map, talk to Dynmap plugin author(s).

fnutt avatar Jan 08 '20 07:01 fnutt

@fnutt considering it works fine with regular nether worlds and considering this is a enhancement it isn’t something bento box needs to fix per say. Obviously this is an enhancement thread to tie bentobox into dynmap if the nether isn’t showing islands correctly this could be a big problem for some server owners. Once again the whole point of this is to make cool addons for bentobox. Not wether or not it needs to be “fixed” by them. Also the end zooming is not something that should be lived with either it works 100% just like the rest of bentobox or don’t bother making it in the first place. Lastly I’m getting the feeling your not understanding this is an enhancement thread and not a bug report. Your last comment would be great if this was a bug report, but it’s not hence why it make no sense.

johncsuti avatar Jan 08 '20 09:01 johncsuti

Well, can we first get the support for overworld map done? ...before trying to make Dynmap plugin authors make changes to their plugin to let you zoom further and hide nether roof. Please.

Babysteps first, implement features one by one.

fnutt avatar Jan 08 '20 10:01 fnutt

Support for the overworld is done aside from markers and other enhancements. All the point of my original post is to fix issues/bugs before this gets released. Furthermore it seems that you are missing a major part of the whole conversation above between me and @Poslovitch where he said “to be confirmed” as in he would ask the author of dynmap on what is wrong with the nether and the end. At this point we don’t need baby steps as the first biggest part is completed and we need to finish implementing the markers and fixing things like the nether and the end.

johncsuti avatar Jan 08 '20 10:01 johncsuti

Finally I would like to reinforce two points. Point one reread the entire conversation between two people before commenting on it. Second get the latest dev build of bentobox and skyblock and test the issue at hand before you go saying “can we get support for the overworld map done?”.

As you would be able to tell by testing that both your comments so far make no sense, since they are done and now all the features and issues need to be done. I am simply putting my findings on issues and enhancements here since there is no addon repository for this.

johncsuti avatar Jan 08 '20 11:01 johncsuti