Benoît Knecht

Results 23 comments of Benoît Knecht

I've rebased once again. Can we get this merged before it diverges again?

You're right, I didn't think about that. It still seems counter-intuitive to me to throw an assertion error when the speed is undefined though. How about checking whether the interface...

While I think this corresponds to the documented behavior, I recognize that it would break configuration that relied on the previous implementation. If you prefer, I can propose a patch...

Looks like [`mypy` is unhappy about `libdnf`](https://dev.azure.com/ansible/ansible/_build/results?buildId=69838&view=logs&j=f39c292d-0a23-56d4-e7e5-386951c14ece&t=3af4f6c8-91cf-5ddb-8873-9e1cb9dedca9&l=361) now though: ``` 01:08 FATAL: Encountered 1 fatal errors reported by mypy: 01:08 lib/ansible/modules/dnf.py:582:1: import: Cannot find implementation or library stub for module...

> Looks like [`mypy` is unhappy about `libdnf`](https://dev.azure.com/ansible/ansible/_build/results?buildId=69838&view=logs&j=f39c292d-0a23-56d4-e7e5-386951c14ece&t=3af4f6c8-91cf-5ddb-8873-9e1cb9dedca9&l=361) now though: > > ``` > 01:08 FATAL: Encountered 1 fatal errors reported by mypy: > 01:08 lib/ansible/modules/dnf.py:582:1: import: Cannot find implementation...

@trevorwhitney There's been two releases of Loki since you merged this into `main`, but somehow this change isn't part of either of them. Is there something I need to do...

> @BenoitKnecht FYI #8797, looking like the end of next week, or early the week after for release. Hey @trevorwhitney, that's great news, thanks for letting me know!

@napaster Have you tried exposing the enclosure to the OS? In my case I was using `perccli`, but the same commands should work with `storcli`: ```console # perccli /c0 set...

@arthanson Sorry for the massive delay, I somehow missed your message. I've added a couple of unit tests, let me know if that's good enough.

@arthanson Could you take another look at this PR? I'd really love to get this merged.