MDPOW icon indicating copy to clipboard operation
MDPOW copied to clipboard

no backwards compatibility for the "watermodel" option of configuration file

Open iorga opened this issue 4 years ago • 3 comments

The "watermodel" option of the configuration file that was present originally in MDPOW was replaced by the more general "solventmodel". Currently, when the "watermodel" option is present in the configuration file, MDPOW ignores it silently and uses the default water model, which is not the desired one.

The backwards compatibility should be ensured for this option.

iorga avatar Apr 22 '21 19:04 iorga

How should this work? Should we just use watermodel as equivalent to solventmodel?

orbeckst avatar Apr 27 '21 01:04 orbeckst

Or would it be better to fail when watermodel is encountered?

orbeckst avatar Apr 27 '21 01:04 orbeckst

Both options are fine for me. Probably use watermodel as equivalent to solventmodel is better, as in reality solventmodel is a synonym of watermodel, but with broader applicability.

iorga avatar Apr 27 '21 04:04 iorga

Given that we are still on 0.x and not API stable, I am going to close and we won't fix it.

orbeckst avatar Oct 14 '24 20:10 orbeckst