GromacsWrapper icon indicating copy to clipboard operation
GromacsWrapper copied to clipboard

Solvate function doesn't support nn and np input

Open VOD555 opened this issue 4 years ago • 4 comments

Related to https://github.com/Becksteinlab/MDPOW/pull/174 In gromacs, one can add a specific number of ions by using keywords nn and np. But in gromacs wrapper solvate function, ions only can be added with the keywords concentration. And concentration keywords only works with some specific water models.

VOD555 avatar Aug 02 '21 22:08 VOD555

@orbeckst i've had a quick look at this and this is indeed correct – there is no support in GromacsWrapper for passing the number of positive/negative ions directly. It could be added in. Do you think it's worth it? What's the next step here? The ticket is a bit old

jandom avatar Nov 11 '23 12:11 jandom

Probably not worth it unless someone really needs it — certainly not urgent.

orbeckst avatar Nov 11 '23 15:11 orbeckst

Should we close then? Or what's the best next step?

jandom avatar Nov 11 '23 15:11 jandom

I am ok with leaving it open — it documents that it is not available yet.

It's also not a "won't fix" — it's just not a priority.

orbeckst avatar Nov 11 '23 15:11 orbeckst