awk-language-server icon indicating copy to clipboard operation
awk-language-server copied to clipboard

Pr snip not work

Open Shane-XB-Qian opened this issue 2 years ago • 9 comments

closes #44

Shane-XB-Qian avatar Apr 10 '23 16:04 Shane-XB-Qian

Looks good. Could you please remove 3 lines mentioned in other comment? And I'll merge.

Beaglefoot avatar Apr 11 '23 04:04 Beaglefoot

remove 3 lines mentioned in other comment

what's that? i did not get you.. :smile:

Shane-XB-Qian avatar Apr 11 '23 04:04 Shane-XB-Qian

you meant not to change snip dict's title which in snippets.json, those 3 lines?

Shane-XB-Qian avatar Apr 11 '23 04:04 Shane-XB-Qian

remove 3 lines mentioned in other comment

what's that? i did not get you.. smile

Totaly forgot to submit review ;)

Beaglefoot avatar Apr 11 '23 05:04 Beaglefoot

and this pr is just trying to solve auto completion for snip from snippets.json but general func/var etc items looks you had to make them to be generated automatically also. // and/or as #45 said, those/you generated items format seems cannot be recognized actually. // and seems you did not impl trigger char feature.

Shane-XB-Qian avatar Apr 11 '23 05:04 Shane-XB-Qian

and did not impl textDocument/signatureHelp feature too. :smile:

Shane-XB-Qian avatar Apr 11 '23 05:04 Shane-XB-Qian

~~update: the auto-compl cannot work perhaps just #45 the generated fmt was not recognized.~~ ~~// just a guess, no way/yet to verify it.~~

Shane-XB-Qian avatar Apr 17 '23 08:04 Shane-XB-Qian

@Beaglefoot perhaps either merge this, or give up snip from lsp server side (rollback that previous snip commit), mostly local may have snip plugin already, that's some kinds of dup. // anyway, #45 should be a good enhance when you have time to refine.

Shane-XB-Qian avatar Jun 19 '23 07:06 Shane-XB-Qian

please refer https://github.com/bash-lsp/bash-language-server/pull/897#issuecomment-1623641500

Shane-XB-Qian avatar Jul 06 '23 13:07 Shane-XB-Qian