bcrypt.net icon indicating copy to clipboard operation
bcrypt.net copied to clipboard

Add support for some old platform

Open wherewhere opened this issue 3 years ago • 7 comments

Could you add netstandard 1.4 and netcore50 to support UWP and other old platform? UWP below rs3 only support netstandard 1.4. Since this project is support old .net version like 2.0. I think it is better to support more platforms. https://github.com/Coolapk-UWP/Coolapk-Lite/tree/master/CoolapkLite%2FBCrypt.Net

wherewhere avatar Sep 26 '22 01:09 wherewhere

Thanks, good to know. One of the major downsides to nuget is you don't know what the codes being used in so that's helpful to know.

I'll drop it into the next minor release once I've checked dotnets targeting matrix thingi to make sure.

.net5 is depreciated in December

ChrisMcKee avatar Sep 26 '22 08:09 ChrisMcKee

Can I push a PR to add the netcore50 and netstandard1.4?

wherewhere avatar Sep 26 '22 11:09 wherewhere

It's not quite as simple as expected as netcore50 breaks in msbuild https://github.com/dotnet/msbuild/issues/5833 Support was dropped.

I can add 1.4 without any real issue; going off https://learn.microsoft.com/en-us/nuget/reference/target-frameworks#portable-class-libraries for a post-pcl world 1.4 is the one to use.


Since this project is support old .net version like 2.0. I think it is better to support more platforms.

v5 of this project will be dropping a lot of the supports; 4 will get maintenance updates after that. Microsofts version-splurge over the last 6 years has made it a mess to contain.

ChrisMcKee avatar Sep 26 '22 12:09 ChrisMcKee

You need install windows 10 sdk to build netcore50. Or you can unzip this .NETCore.zip to C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework.

wherewhere avatar Sep 26 '22 12:09 wherewhere

Take a try https://github.com/wherewhere/bcrypt.net

wherewhere avatar Sep 26 '22 12:09 wherewhere

Yep you nailed it with the windows 10sdk bit; I hadn't clocked that VS had removed it when 22 came out (Don't really do any UWP / Store stuff personally).

I'll let you know when its in nuget 👍

ChrisMcKee avatar Sep 26 '22 13:09 ChrisMcKee

So can I push my commit? (I remove the net5 and add netstandard1.4 netcore50 netcoreapp3.1 and update net4.8 to 4.8.1 (I also update old csproj to new sdk one...

wherewhere avatar Sep 26 '22 13:09 wherewhere