sigutils icon indicating copy to clipboard operation
sigutils copied to clipboard

Generated PC files may cause include shadowing

Open antoniovazquezblanco opened this issue 2 years ago • 4 comments

For compat reasons, PC files generated by sigutils force to include second level directories via CFLAGS.

It would be best to avoid this but it breaks compilation of suscan and sigdigger. This means that this fix must be timed adecuatedly.

Refs: https://github.com/BatchDrake/sigutils/pull/53

antoniovazquezblanco avatar Apr 17 '23 19:04 antoniovazquezblanco

Having a deeper look at the issue, the current includes structure is:

include
    └───sigutils
        └───sigutils
            ├───specific
            └───util

A possible fix may be to reestructure to:

include
    └───sigutils
        ├───specific
        └───util

and simultaneously remove the conflicting include parameter.

To be studied...

antoniovazquezblanco avatar Apr 17 '23 19:04 antoniovazquezblanco

Partial fix in https://github.com/BatchDrake/sigutils/pull/55

Following steps require fixes in Suscan and Sigdigger. If includes are fixed in this dependent programs, the ofending PC lines can be removed afterwards.

antoniovazquezblanco avatar Apr 24 '23 07:04 antoniovazquezblanco

Improved include practices in:

https://github.com/BatchDrake/suscan/pull/67 https://github.com/BatchDrake/SigDigger/pull/206 https://github.com/BatchDrake/SuWidgets/pull/20

This is another partial fix to the issue. After all the mentioned issues are tested and merged, finally, the ofending PC lines can be removed.

antoniovazquezblanco avatar May 03 '23 08:05 antoniovazquezblanco

All ofending imports have been fixed. Theoretically, level directory inclusion CFLAGS can be removed at the moment.

In order to prevent possible compilation errors with older versions of SigDigger and Suscan with newer Sigutil versions, it may be interesting to postpone this issue fix for a release.

antoniovazquezblanco avatar May 10 '23 08:05 antoniovazquezblanco