bash-it icon indicating copy to clipboard operation
bash-it copied to clipboard
verified publisher icon Bash-it

`shellcheck` all core files

Open gaelicWizard opened this issue 4 years ago • 7 comments

Description

Add custom, lib, scripts, and template to clean_files.txt and address the fallout. This helps towards #1696.

Motivation and Context

My entire glob branch would have been unnecessary if these files had been checked by spellcheck, so let's do it!

How Has This Been Tested?

All tests pass!

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] If my change requires a change to the documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • [x] I have added tests to cover my changes, and all the new and existing tests pass.

gaelicWizard avatar Aug 13 '21 06:08 gaelicWizard

This is a draft as it is a work-in-progress!

This branch is based on uname, basename, and brew, so those PRs are assumed to have been accepted before this one. (Otherwise there are a lot of unrelated changes in here!)

gaelicWizard avatar Aug 13 '21 06:08 gaelicWizard

IMO, this is too much risk for one PR : 24 files?

It's like six files, only one of which I've (partially) committed. The rest you see in the list are from a different PR, which has been approved but not merged yet. This PR is a draft because it's not ready yet.

Worry not, it will be clean and clear before submission! 👍

gaelicWizard avatar Aug 15 '21 00:08 gaelicWizard

This is a draft as it is a work-in-progress!

This branch is based on uname, basename, and brew, so those PRs are assumed to have been accepted before this one. (Otherwise there are a lot of unrelated changes in here!)

(Just rebased on master since uname has been merged.)

gaelicWizard avatar Aug 15 '21 01:08 gaelicWizard

All tests are passing, but this branch grew significantly so I will try to split it up a bit in separate PRs. The number of files actually changed here for shellcheck should be 7-10; the rest are from the prerequisite PRs that aren't merged yet.

gaelicWizard avatar Sep 09 '21 07:09 gaelicWizard

Ok! This PR is still pretty big, but it's now narrowed down to specifically linting these files. I'm leaving it marked as draft as smaller PRs are more likely to go through sooner.

gaelicWizard avatar Sep 20 '21 20:09 gaelicWizard

Rebased on current master. This PR no longer contains any unrelated changes to specifically shellcheck (and shfmt), as the prerequisite PRs have already been merged. 👍

gaelicWizard avatar Oct 10 '21 04:10 gaelicWizard