flutter-geolocator icon indicating copy to clipboard operation
flutter-geolocator copied to clipboard

`geolocator_android`: Update dependencies

Open Zazo032 opened this issue 2 years ago • 1 comments

  • Updates dependencies to latest versions to prevent conflicts with other packages.
  • Updates Android Gradle Plugin to version 8.
  • Updates compileSdk version to 34.

Follow-up of https://github.com/Baseflow/flutter-geolocator/pull/1347

https://github.com/Baseflow/flutter-geolocator/issues/1348

Pre-launch Checklist

  • [ ] I made sure the project builds.
  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • [ ] I updated CHANGELOG.md to add a description of the change.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I rebased onto main.
  • [ ] I added new tests to check the change I am making, or this PR does not need tests.
  • [ ] I made sure all existing and new tests are passing.
  • [ ] I ran dart format . and committed any changes.
  • [ ] I ran flutter analyze and fixed any errors.

Zazo032 avatar Oct 03 '23 13:10 Zazo032

Is something holding this from being merged?

emakar avatar Jan 29 '24 15:01 emakar

Closing this PR as it is a bit outdated and comments regarding my concerns have not been addressed.

Recent attempts to update Android Gradle Plugin showed breaking changes for users still depending on AGP 7.0 or below. Flutter officially supports AGP 7.0 and higher as mentioned also in the recent release description for Flutter 3.22:

Flutter tool enforces version requirements on Gradle, AGP, Java, and Kotlin In this release, the Flutter tool enforces a policy regarding the versions that it supports for Gradle, the Android Gradle Plugin (AGP), Java, and Kotlin. Initially, the tool only provides warnings.

Currently, the supported version ranges are as follows:

Gradle — Fully supported 7.0.2 to current, warn otherwise AGP — Fully supported 7.0.0 to current, warn otherwise Java — Fully supported Java 11 to current, warn otherwise Kotlin — Fully supported 1.5.0 to current, warn otherwise

mvanbeusekom avatar May 16 '24 07:05 mvanbeusekom