flutter-geocoding icon indicating copy to clipboard operation
flutter-geocoding copied to clipboard

feat!: renamed package `geocoding_ios` to `geocoding_darwin`

Open OutdatedGuy opened this issue 1 year ago • 3 comments

Renames geocoding_ios to geocoding_darwin to later add macOS support. Will follow up with macOS support PR after this is merged.

resolves #244

Pre-launch Checklist

  • [x] I made sure the project builds.
  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • [x] I updated CHANGELOG.md to add a description of the change.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I rebased onto main.
  • [ ] I added new tests to check the change I am making, or this PR does not need tests.
  • [x] I made sure all existing and new tests are passing.
  • [x] I ran dart format . and committed any changes.
  • [x] I ran flutter analyze and fixed any errors.

OutdatedGuy avatar Aug 23 '24 00:08 OutdatedGuy

@mvanbeusekom @JeroenWeener can you guys review this PR?

OutdatedGuy avatar Oct 07 '24 13:10 OutdatedGuy

@OutdatedGuy can you do a rebase on this PR?

martijn00 avatar Oct 08 '24 08:10 martijn00

@OutdatedGuy can you do a rebase on this PR?

@martijn00 Done ✅

OutdatedGuy avatar Oct 08 '24 11:10 OutdatedGuy

@martijn00 @mvanbeusekom @JeroenWeener any idea when this PR will be reviewed?

OutdatedGuy avatar Apr 15 '25 05:04 OutdatedGuy

Closing due to lots of merge conflicts. Will submit a new one

OutdatedGuy avatar Jul 27 '25 23:07 OutdatedGuy