XamarinMediaManager icon indicating copy to clipboard operation
XamarinMediaManager copied to clipboard

Adds step to prepare() when calling PlayQueueItem

Open szurgot opened this issue 2 years ago • 3 comments

Upgrading Windows SDK version to address version downgrade

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix.

:arrow_heading_down: What is the current behavior?

When starting a queue from PlayQueueItem, the media plays, but when play is subsequently called, it restarts the queue

:new: What is the new behavior (if this is a feature change)?

Calling pause and play now behave appropriate after starting a queue with PlayQueueItem

:boom: Does this PR introduce a breaking change?

No.

:bug: Recommendations for testing

Test using an app the loads a queue then starts any item with PlayQueueItem.

:memo: Links to relevant issues/docs

https://github.com/Baseflow/XamarinMediaManager/issues/856

:thinking: Checklist before submitting

  • [ X ] All projects build
  • [ X ] Follows style guide lines
  • [ X ] Relevant documentation was updated
  • [ X ] Rebased onto current develop

szurgot avatar Sep 22 '23 22:09 szurgot

Thanks for looking into this @szurgot Shouldn't the change also be done here?

janwiebe-jump avatar Oct 05 '23 06:10 janwiebe-jump

Yes. Let me fix that.

szurgot avatar Oct 05 '23 16:10 szurgot

@janwiebe-jump Updated the code so that PlayQueueItem prepares in both instances. Also refactored to eliminate the duplication in those methods.

szurgot avatar Oct 05 '23 16:10 szurgot