obs-websocket-dotnet icon indicating copy to clipboard operation
obs-websocket-dotnet copied to clipboard
verified publisher icon BarRaider

Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events

Open DrEsteban opened this issue 1 year ago • 4 comments

This contains fixes for the issues described in:

  • https://github.com/BarRaider/obs-websocket-dotnet/issues/136
  • https://github.com/BarRaider/obs-websocket-dotnet/issues/138

It also contains:

  • Build enhancements

DrEsteban avatar May 21 '24 16:05 DrEsteban

Multiple small pull requests is probably better than one big one

BarRaider avatar May 22 '24 06:05 BarRaider

You're not wrong haha. But some of the concerns may cause merge conflicts with each other - e.g. the ILogger and UnsupportedEvent, since they touch lines right next to each other.

Would you like me to split it up as follows?:

  1. ILogger + UnsupportedEvent changes
  2. Other Model changes/fixes

DrEsteban avatar May 22 '24 17:05 DrEsteban

Hey @DrEsteban are you still working on this; or do you need someone else to take over?

chapterjason avatar Oct 06 '24 00:10 chapterjason

@BarRaider @chapterjason Finally got around to splitting this up. Second PR is #143.

Feel free to submit fixes or change requests as desired.

DrEsteban avatar Oct 19 '24 00:10 DrEsteban

@BarRaider friendly ping! Any feedback here?

DrEsteban avatar Nov 11 '24 09:11 DrEsteban

Anybody want to accept this and merge it?

DrEsteban avatar Jan 06 '25 22:01 DrEsteban

Heya, any updates on this feature? Was glad to see someone was already working on this before I tried to create a workaround.

BluRael avatar Apr 07 '25 21:04 BluRael

@BarRaider friendly ping

DrEsteban avatar Apr 09 '25 15:04 DrEsteban

Hi @BarRaider, friendly nudge for this one

BluRael avatar Apr 21 '25 19:04 BluRael

Will take a look this week

BarRaider avatar Apr 21 '25 20:04 BarRaider

LGTM - Thank you!

BarRaider avatar Apr 22 '25 18:04 BarRaider