variants icon indicating copy to clipboard operation
variants copied to clipboard

Flag to decide whether or not match_params are auto-generated

Open bb-jeriel opened this issue 4 years ago • 3 comments

Background

  • Currently, it appears that match params are generated based off the match_params_template.rb file. If we do not wish to use some of these parameters and choose to remove them, they regenerate automatically anytime the Variants command is run.

Solution

  • Provide a flag that determines whether some of these params should be automatically added

bb-jeriel avatar Jun 10 '21 16:06 bb-jeriel

@bb-jeriel can you give specific examples of parameters you don't wish to have in match_params.rb?

arthurpalves avatar Feb 13 '23 11:02 arthurpalves

Todo: Update params template so that auto generated/updated are below and provide comments so that users know what can/should be manually changed.

arthurpalves avatar Mar 17 '23 10:03 arthurpalves

Hi @bb-jeriel, thanks for raising the issue. In order to proceed we will need a bit more information on what is the expectation here. Variants will always write to the match_params.rb all related properties coming from the variants.yml file. If a certain property is coming with the wrong value that should be updated in the variants.yml itself. If a property is not being used we can simply ignore it. If we want to configure per param basis which ones should or shouldn't go to the match_params.rb, that means one extra property for each (or a list of properties), which can be quite cumbersome to use. One approach here could be a property that skips completely writing to the match_params.rb file. This achieves the desired but has side effects as the file will be in desync with the project. Do you have any examples of how you see this functionality?

GMinucci avatar Jan 27 '25 14:01 GMinucci