redner icon indicating copy to clipboard operation
redner copied to clipboard

Error in batch render test

Open dgriffiths3 opened this issue 5 years ago • 3 comments

When running the batch test script line 15:

h, w = args_old_format[11]

should be:

h, w = args_old_format[12]

Has there been a change to break this recently? The rest of the script runs fine, but I wonder if there could be other underlying issues with the other args as a result of being shifted 1 place that aren't so obvious.

dgriffiths3 avatar Sep 17 '20 09:09 dgriffiths3

Thanks for catching this! You're correct. In general this function is outdated -- there's a wrapper in pyredner/render_utils.py that should handle batch rendering. I should probably remove this file.

BachiLi avatar Sep 18 '20 20:09 BachiLi

Okay thanks. So is the correct way to do batch rendering to just simply pass in a list of scenes to the deferred/generic rendering function?

dgriffiths3 avatar Sep 21 '20 09:09 dgriffiths3

Yes. In the future we may have more efficient ways to do this -- still figuring out.

BachiLi avatar Sep 22 '20 15:09 BachiLi