Editor icon indicating copy to clipboard operation
Editor copied to clipboard
verified publisher icon BabylonJS

The source Editor cannot be built in Node v17

Open eherozhao opened this issue 3 years ago • 4 comments

My node was v17 in the past and it failed to built the Editor source code. After installing to v16, I can build the Editor from scratch. Do we have any documentation related to the requirement of the Editor like supported Node version?

eherozhao avatar Apr 21 '22 00:04 eherozhao

Hi @eherozhao ! I just reproduced and I'm trying to find a fix for that. Node.JS 17 should be supported

julien-moreau avatar Apr 26 '22 17:04 julien-moreau

I noticed the Editor was updated to newer version. Is this issue solved? If it is, please feel free to close this issue.

eherozhao avatar Apr 30 '22 03:04 eherozhao

Hi @eherozhao ! Unfortunately not and it looks like the problem comes from the module node-pty which uses deprecated Node.JS C++ Api. I'm still digging. Do you confirm that you can't use Node.JS 16 ?

julien-moreau avatar May 03 '22 17:05 julien-moreau

I can definitely use Node 16 and it was what I used to fix the problem. I don't think we need an urgent fix for Node 17. Thank you for your help.

eherozhao avatar May 03 '22 17:05 eherozhao