lib_oled96 icon indicating copy to clipboard operation
lib_oled96 copied to clipboard

Speed up the pixels to page bytes conversion

Open Tey opened this issue 9 years ago • 2 comments

First, thanks for your work on that lib!

These changes should improve the speed of the ssd1306.display() method. My testings indicate they speed up the conversion by a 2x factor, so you might want to apply them. They don't double the FPS though, but I'm able to get 25 FPS with them which was not possible with original implementation.

Tey avatar Dec 09 '16 10:12 Tey

Thanks Tey, I'm not in a position to look at this just now. Away from home (Australia), wandering around the north-east of Mexico. Won't be home until late January. If you wanted to fork the whole thing yourself, feel free. Or we can wait. The process of PULL to incorporating contributed changes I have not ever tried to master, and I don't have leisure to attempt it from here. Regards Brian

On 9 December 2016 at 05:20, Tey [email protected] wrote:

First, thanks for your work on that lib!

These changes should improve the speed of the ssd1306.display() method. My testings indicate they speed up the conversion by a 2x factor, so you might want to apply them.

You can view, comment on, or merge this pull request online at:

https://github.com/BLavery/lib_oled96/pull/2 Commit Summary

  • Speed up the pixels to page bytes conversion

File Changes

Patch Links:

  • https://github.com/BLavery/lib_oled96/pull/2.patch
  • https://github.com/BLavery/lib_oled96/pull/2.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BLavery/lib_oled96/pull/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AIYX1YX7n0OZ-88EAinyxSBJS36UFbsuks5rGStjgaJpZM4LIyC6 .

BLavery avatar Dec 09 '16 23:12 BLavery

No problem, there's no hurry. If you need help to understand how pull requests work, just ask :)

Tey avatar Dec 10 '16 08:12 Tey