BHoM_Engine icon indicating copy to clipboard operation
BHoM_Engine copied to clipboard

Reflection/Serialiser Engine - methods in wrong namespace?

Open FraserGreenroyd opened this issue 5 years ago • 0 comments

The following 4 methods are saying (and their CS files confirm) that they are part of the Serialiser_Engine namespace.

However, the files that contain the code, sit within the Reflection_Engine project.

Is this correct @adecler ? It feels like it might be an accident and they should all be BH.Engine.Reflection instead? Or is this deliberate for injection from Reflection Engine into Serialiser space? @adecler to answer with confirmation it's deliberate, or recommend for a PR to fix (with versioning as appropriate) :smile:

  • BH.Engine.Serialiser.Create.MethodBase(Type type, String methodName, List paramTypeNames) - file path = Reflection_Engine/Create/MethodBase.cs
  • BH.Engine.Serialiser.Create.MethodBase(Type type, String methodName, List paramTypes) - file path = Reflection_Engine/Create/MethodBase.cs
  • BH.Engine.Serialiser.Query.GenericTypeConstraint(Type type) - file path = Reflection_Engine/Query/GenericTypeConstraint.cs
  • BH.Engine.Serialiser.Query.ParametersWithConstraints(MethodBase method) - file path = Reflection_Engine/Query/ParametersWithConstraints.cs

FraserGreenroyd avatar Apr 07 '21 16:04 FraserGreenroyd