Lag issue from Wildstacker

[ArefyNetwork]

Minecraft's Version

Paper spigot 1.8.8

Plugin's Version

WildStacker-2023.3-b33

Describe the bug

Wildstacker it's lagging a lot when you've fast-kill and one-shoot enabled, as players can kill a large amount of mobs per second, so I assume it fires too many times the on mob kill listener

Spark: https://spark.lucko.me/tWWQ7gbyXK

Thanks for any help!

To Reproduce

Just set fast-kill and one-shoot to true and then if many players are farming on their islands, server will start giving low tps

Additional Information

No response

[OmerBenGera]

The lag comes from other plugins that listen to the death event, but mainly from the amount of items that spawn. I can try and look for neaby items, potentially stack them instead of spawning them, hopefully it will improve performance. However, the lag from other plugins needs to be reported to their authors.

[ArefyNetwork]

The lag comes from other plugins that listen to the death event, but mainly from the amount of items that spawn. I can try and look for neaby items, potentially stack them instead of spawning them, hopefully it will improve performance. However, the lag from other plugins needs to be reported to their authors.

Hey Omer, thanks for your answer, but without one-shoot and fast-kill features disabled it works well, so listeners are fired too fast I assume with one-shoot and fast-kill enabled

[OmerBenGera]

The lag comes from other plugins that listen to the death event, but mainly from the amount of items that spawn. I can try and look for neaby items, potentially stack them instead of spawning them, hopefully it will improve performance. However, the lag from other plugins needs to be reported to their authors.

Hey Omer, thanks for your answer, but without one-shoot and fast-kill features disabled it works well, so listeners are fired too fast I assume with one-shoot and fast-kill enabled

When you have one-shoot and fast kill, many more events are fired, and in more frequent delay. This causes other plugins to lag even more than usual, making the lag you see. However, as I stated, there is some lag from WildStacker itself, which I will look into fixing.

[ArefyNetwork]

The lag comes from other plugins that listen to the death event, but mainly from the amount of items that spawn. I can try and look for neaby items, potentially stack them instead of spawning them, hopefully it will improve performance. However, the lag from other plugins needs to be reported to their authors.

Hey Omer, thanks for your answer, but without one-shoot and fast-kill features disabled it works well, so listeners are fired too fast I assume with one-shoot and fast-kill enabled

When you have one-shoot and fast kill, many more events are fired, and in more frequent delay. This causes other plugins to lag even more than usual, making the lag you see. However, as I stated, there is some lag from WildStacker itself, which I will look into fixing.

Sure, much appreciated! Also could you say whenever you can which are the plugins that are caussing that lag apart from wildstacker itself and infinitechest? I'll use wildchests next time as it should be more optimized

Thanks!

[ArefyNetwork]

Upping this, sorry for bother you again Omer, but I'm still having lag with that

https://spark.lucko.me/OMFKZg4JJk

(And also now I'm getting this crash when many entities spawning, I don't know if it has anything to do with the spark profiler): https://paste.helpch.at/itaqikuqec.makefile

Thanks again!

[OmerBenGera]

The lag seems to be caused by net.advancedplugins.ae.impl.effects.effects.mechanics.triggers.internal.KillMobTrigger.onMobDeath(), net.advancedplugins.ae.items.AEItem.onEntityDeath(), me.rivaldev.rivalpets.buffs.types.vanilla.MobKillBuff.onBoost() and others. As I wrote above, this is not caused by WildStacker - it's due to other plugins cannot handle too many entities killed.